Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions to use YYYY.WW.REV for release versions. #100

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Update instructions to use YYYY.WW.REV for release versions. #100

merged 5 commits into from
Oct 7, 2024

Conversation

DavidSouther
Copy link
Contributor

Issue #, if available: Closes #98

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DavidSouther DavidSouther added Enhancement A general update to the code base. Task A general update to the code base for language clarification, missing actions, tests, etc. labels Oct 1, 2024
@DavidSouther DavidSouther marked this pull request as ready for review October 1, 2024 14:06
Laren-AWS
Laren-AWS requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this makes sense and should ease some of the pain.

I found a few issues while testing stamp.sh.

README.md Outdated Show resolved Hide resolved
stamp.sh Outdated Show resolved Hide resolved
stamp.sh Outdated Show resolved Hide resolved
stamp.sh Outdated Show resolved Hide resolved
Laren-AWS
Laren-AWS requested changes Oct 7, 2024
View reviewed changes
stamp.sh Outdated Show resolved Hide resolved
@DavidSouther DavidSouther self-assigned this Oct 7, 2024
@DavidSouther DavidSouther merged commit bf06155 into main Oct 7, 2024
2 checks passed
@DavidSouther DavidSouther deleted the docs/release/date_based_semver branch November 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laren-AWS Laren-AWS Laren-AWS approved these changes

Assignees

@DavidSouther DavidSouther

Labels
Enhancement A general update to the code base. Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use date-based build stamps for setup.py versioning
2 participants
@DavidSouther @Laren-AWS